Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Use storage: auto for recovery/ddb.py #12253

Merged
merged 2 commits into from
Jun 4, 2023
Merged

test: Use storage: auto for recovery/ddb.py #12253

merged 2 commits into from
Jun 4, 2023

Conversation

mjmac
Copy link
Contributor

@mjmac mjmac commented Jun 1, 2023

Required-githooks: true

Signed-off-by: Michael MacDonald [email protected]

@mjmac mjmac requested a review from a team as a code owner June 1, 2023 12:25
@github-actions
Copy link

github-actions bot commented Jun 1, 2023

Bug-tracker data:
Errors are component not formatted correctly,Ticket number prefix incorrect,PR title is malformatted. See https://daosio.atlassian.net/wiki/spaces/DC/pages/11133911069/Commit+Comments,Unable to load ticket data
https://daosio.atlassian.net/browse/test:

daosbuild1
daosbuild1 reviewed Jun 1, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@mjmac
test: Use storage: auto for recovery/ddb.py
a95f5b0 
Features: recovery

Required-githooks: true

Signed-off-by: Michael MacDonald <[email protected]>
@mjmac mjmac force-pushed the mjmac/cr-fix-ddb-tests branch from e1f91f2 to a95f5b0 Compare June 1, 2023 14:06
daosbuild1
daosbuild1 reviewed Jun 1, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

daltonbohning
daltonbohning approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@daltonbohning daltonbohning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming this works and passes

src/tests/ftest/recovery/ddb.yaml Outdated
class: ram
scm_mount: /mnt/daos
scm_size: 5
storage: auto
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phender Does this work for VMs? (cat_recovery branch)

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12253/2/execution/node/1090/log

daosbuild1
daosbuild1 reviewed Jun 2, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@mjmac
Don't use storage: auto
c82ceb2 
It mounts the tmpfs somewhere other than where the
test expects it...

Features: recovery
Required-githooks: true

Signed-off-by: Michael MacDonald <[email protected]>
@mjmac mjmac force-pushed the mjmac/cr-fix-ddb-tests branch from 7c07542 to c82ceb2 Compare June 2, 2023 20:47
daosbuild1
daosbuild1 reviewed Jun 2, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12253/4/execution/node/1090/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12253/5/execution/node/601/log

@mjmac mjmac merged commit c9e76d4 into feature/cat_recovery Jun 4, 2023
@mjmac mjmac deleted the mjmac/cr-fix-ddb-tests branch June 4, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daosbuild1 daosbuild1 daosbuild1 left review comments

@daltonbohning daltonbohning daltonbohning approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjmac @daosbuild1 @daltonbohning