DAOS-13066 test: Reduce concurrency in NLT #12112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required-githooks: true Signed-off-by: Ashley Pittman <[email protected]>
|
Bug-tracker data: |
daosbuild1
reviewed
May 9, 2023
|
Test stage Functional on EL 8 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-12112/1/display/redirect |
daosbuild1
reviewed
May 9, 2023
Required-githooks: true
daosbuild1
reviewed
May 11, 2023
daosbuild1
reviewed
May 12, 2023
Required-githooks: true Signed-off-by: Ashley Pittman <[email protected]>
daosbuild1
reviewed
May 12, 2023
Required-githooks: true Signed-off-by: Ashley Pittman <[email protected]>
daosbuild1
reviewed
May 12, 2023
Required-githooks: true Signed-off-by: Ashley Pittman <[email protected]>
ashleypittman
force-pushed
the
amd/nlt-concurrency
branch
from
0d0b9a6 to
2d010e8
Compare
daosbuild1
reviewed
May 12, 2023
Required-githooks: true Signed-off-by: Ashley Pittman <[email protected]>
Required-githooks: true
Required-githooks: true Signed-off-by: Ashley Pittman <[email protected]>
daosbuild1
reviewed
May 15, 2023
|
Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12112/9/execution/node/1187/log |
daltonbohning
approved these changes
May 15, 2023
| @@ -3812,7 +3799,7 @@ def _run_test(ptl=None, function=None, test_cb=None): | |||
| # long-running tests which dominate the time, so whilst a higher value here would | |||
| # work there's no benefit in rushing to finish the quicker tests. The long-running | |||
| # tests are started first. | |||
| while len(threads) > 5: | |||
| while len(threads) > 4: | |||
There was a problem hiding this comment.
Should 4 be a global or class constant?
There was a problem hiding this comment.
or a command line variable? I think here is as good as anywhere.
|
This seems to reduce the number of failures we're getting from the NLT test in CI currently. |
mchaarawi
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required-githooks: true
Signed-off-by: Ashley Pittman [email protected]