-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAOS-13117 chk: properly set pool label in check report upcall #11896
Conversation
The cpr->cpr_label is empty for orphan pool, that will confuse related MS logic when handle the check report upcall. So under such case, we should use PS pool label in the check report upcall. The patch also fixes another issue when handle broken pool without pool service quorum. For such case, it uses ds_chk_regpool_upcall() to notify MS to refresh related pool service replicas. But at that time, we do not know whether related pool label (between MS and PS) is consistent or not. Under such case, we should use MS pool label instead of PS label to avoid over-writting MS pool label by wrong. Signed-off-by: Fan Yong <[email protected]>
Bug-tracker data: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No errors found by checkpatch.
Test stage Build on Leap 15.4 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-11896/1/execution/node/503/log |
Test stage Build on Leap 15.4 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-11896/2/execution/node/412/log |
3be592a
to
e76a4df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No errors found by checkpatch.
Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-11896/3/execution/node/1189/log |
rebuild simple failed for DAOS-12244, not related with the patch. |
The cpr->cpr_label is empty for orphan pool, that will confuse related MS logic when handle the check report upcall. So under such case, we should use PS pool label in the check report upcall.
The patch also fixes another issue when handle broken pool without pool service quorum. For such case, it uses ds_chk_regpool_upcall() to notify MS to refresh related pool service replicas. But at that time, we do not know whether related pool label (between MS and PS) is consistent or not. Under such case, we should use MS pool label instead of PS label to avoid over-writting MS pool label by wrong.
Before requesting gatekeeper:
Features:
(orTest-tag*
) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.Gatekeeper: