Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-12189 chk: Include removed pools in query count #11746

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

mjmac
Copy link
Contributor

@mjmac mjmac commented Mar 20, 2023

When a pool has been removed, it will no longer appear
in the pools list for the response. We can still detect
that a pool was removed by checking the reports list,
however. If we find a removed pool, include in the count
of checked pools when displaying the query results.

Includes misc. improvements to JSON output as well.

Features: recovery

Required-githooks: true

Signed-off-by: Michael MacDonald [email protected]

When a pool has been removed, it will no longer appear
in the pools list for the response. We can still detect
that a pool was removed by checking the reports list,
however. If we find a removed pool, include in the count
of checked pools when displaying the query results.

Includes misc. improvements to JSON output as well.

Features: recovery

Required-githooks: true

Signed-off-by: Michael MacDonald <[email protected]>
@mjmac mjmac requested a review from a team as a code owner March 20, 2023 16:54
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@github-actions
Copy link

Bug-tracker data:
Ticket title is 'CR Pass 5 - CONT_BAD_LABEL interactive mode doesn't show repair options properly'
Status is 'Resolved'
Labels: 'triaged'
https://daosio.atlassian.net/browse/DAOS-12189

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-11746/1/execution/node/1227/log

@mjmac mjmac merged commit 7c5e443 into feature/cat_recovery Mar 21, 2023
@mjmac mjmac deleted the mjmac/cr-count-pools branch March 21, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants