Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-12470 chk: misc fixes for chk related issues - I #11440

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

Nasf-Fan
Copy link
Contributor

@Nasf-Fan Nasf-Fan commented Feb 13, 2023

It contains the following fixes:

  1. Protect pool service start/stop by cpr_mutex to handle concurrent access from check logic by race.

  2. Typo for flag usage in chk_engine_start_prep() logic.

  3. Do not skip IV message for the notification from check leader
    to the check engine that resides on the check leader rank.

  4. Use CRT_IV_SYNC_NONE when IV update from check engine to the
    check leader to avoid broadcast IV message to all engines.

  5. More log messages after check logic done (for pool start).

Signed-off-by: Fan Yong [email protected]

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

It contains the following fixes:

1. Protect pool service start/stop by cpr_mutex to handle
   concurrent access from check logic by race.

2. Typo for flag usage in chk_engine_start_prep() logic.

3. Do not skip IV message for the notification from check leader
   to the check engine that resides on the check leader rank.

4. Use CRT_IV_SYNC_NONE when IV update from check engine to the
   check leader to avoid broadcast IV message to all engines.

5. More log messages after check logic done (for pool start).

Signed-off-by: Fan Yong <[email protected]>
@github-actions
Copy link

Bug-tracker data:
Ticket title is 'start_gc_ult() Assertion 'child->spc_gc_req == NULL' failed'
Status is 'In Progress'
https://daosio.atlassian.net/browse/DAOS-12470

Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-12470_1 branch from a0107eb to 7fe5642 Compare February 13, 2023 15:10
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-12470_1 branch from 7fe5642 to 5b9b0c4 Compare February 13, 2023 16:08
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-12470_1 branch from 5b9b0c4 to 2f73cfe Compare February 13, 2023 16:37
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@Nasf-Fan Nasf-Fan marked this pull request as ready for review February 14, 2023 14:02
@Nasf-Fan Nasf-Fan requested a review from a team February 16, 2023 00:25
@mjmac mjmac merged commit 44c7d2b into feature/cat_recovery Feb 17, 2023
@mjmac mjmac deleted the Nasf-Fan/DAOS-12470_1 branch February 17, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants