-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAOS-12470 chk: misc fixes for chk related issues - I #11440
Conversation
It contains the following fixes: 1. Protect pool service start/stop by cpr_mutex to handle concurrent access from check logic by race. 2. Typo for flag usage in chk_engine_start_prep() logic. 3. Do not skip IV message for the notification from check leader to the check engine that resides on the check leader rank. 4. Use CRT_IV_SYNC_NONE when IV update from check engine to the check leader to avoid broadcast IV message to all engines. 5. More log messages after check logic done (for pool start). Signed-off-by: Fan Yong <[email protected]>
Bug-tracker data: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No errors found by checkpatch.
a0107eb
to
7fe5642
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No errors found by checkpatch.
7fe5642
to
5b9b0c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No errors found by checkpatch.
5b9b0c4
to
2f73cfe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No errors found by checkpatch.
It contains the following fixes:
Protect pool service start/stop by cpr_mutex to handle concurrent access from check logic by race.
Typo for flag usage in chk_engine_start_prep() logic.
Do not skip IV message for the notification from check leader
to the check engine that resides on the check leader rank.
Use CRT_IV_SYNC_NONE when IV update from check engine to the
check leader to avoid broadcast IV message to all engines.
More log messages after check logic done (for pool start).
Signed-off-by: Fan Yong [email protected]
Before requesting gatekeeper:
Features:
(orTest-tag*
) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.Gatekeeper: