DAOS-16833 cq: update GHA ubuntu (#15538) (#15563)

Update mantic (EOL) to oracular. Update 22.04 LTS to 24.04 LTS. Signed-off-by: Dalton Bohning <[email protected]>
daos-stack · Dec 16, 2024 · db14b84 · db14b84
1 parent a4f8be7
commit db14b84
Show file tree

Hide file tree

Showing 9 changed files with 26 additions and 25 deletions.
diff --git a/.github/workflows/ci2.yml b/.github/workflows/ci2.yml
@@ -15,7 +15,7 @@ jobs:
   # from scratch, but do not save them.
   Build-and-test:
     name: Run DAOS/NLT tests
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     permissions:
       # https://github.com/EnricoMi/publish-unit-test-result-action#permissions
       checks: write
@@ -26,7 +26,7 @@ jobs:
         include:
           - distro: ubuntu
             base: ubuntu
-            with: ubuntu:mantic
+            with: ubuntu:oracular
     env:
       DEPS_JOBS: 10
       COMPILER: clang
@@ -76,7 +76,7 @@ jobs:
 
   Build:
     name: Build DAOS
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     strategy:
       fail-fast: false
       matrix:

diff --git a/.github/workflows/landing-builds.yml b/.github/workflows/landing-builds.yml
@@ -35,7 +35,7 @@ jobs:
   # for distros where we only want to build on master and not PRs see the Build-branch job below.
   Prepare:
     name: Create Docker images
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     strategy:
       fail-fast: false
       max-parallel: 1
@@ -44,7 +44,7 @@ jobs:
         include:
           - distro: ubuntu
             base: ubuntu
-            with: ubuntu:mantic
+            with: ubuntu:oracular
           - distro: rocky
             base: el.9
             with: rockylinux/rockylinux:9
@@ -88,7 +88,7 @@ jobs:
   Build-and-test:
     name: Run DAOS/NLT tests
     needs: Prepare
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     permissions:
       # https://github.com/EnricoMi/publish-unit-test-result-action#permissions
       checks: write
@@ -99,7 +99,7 @@ jobs:
         include:
           - distro: ubuntu
             base: ubuntu
-            with: ubuntu:mantic
+            with: ubuntu:oracular
     env:
       DEPS_JOBS: 10
       BASE_DISTRO: ${{ matrix.with }}
@@ -148,7 +148,7 @@ jobs:
   Build:
     name: Build DAOS in image
     needs: Prepare
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     strategy:
       fail-fast: false
       max-parallel: 2
@@ -158,7 +158,7 @@ jobs:
         include:
           - distro: ubuntu
             base: ubuntu
-            with: ubuntu:mantic
+            with: ubuntu:oracular
           - distro: rocky
             base: el.9
             with: rockylinux/rockylinux:9
@@ -226,7 +226,7 @@ jobs:
 
   Build-branch:
     name: Build DAOS
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     strategy:
       fail-fast: false
       matrix:
@@ -322,7 +322,7 @@ jobs:
         include:
           - distro: ubuntu
             base: ubuntu
-            with: ubuntu:mantic
+            with: ubuntu:oracular
           - distro: alma.8
             base: el.8
             with: almalinux:8

diff --git a/.github/workflows/linting.yml b/.github/workflows/linting.yml
@@ -36,7 +36,7 @@ jobs:
 
   shell-check:
     name: ShellCheck
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     steps:
       - name: Checkout code
         uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11  # v4.1.1
@@ -54,7 +54,7 @@ jobs:
 
   log-check:
     name: Logging macro checking
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     steps:
       - name: Checkout code
         uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11  # v4.1.1
@@ -65,15 +65,15 @@ jobs:
 
   ftest-tags:
     name: Ftest tag check
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     steps:
       - name: Checkout code
         uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11  # v4.1.1
       - name: Check DAOS ftest tags.
         run: \[ ! -x src/tests/ftest/tags.py \] || ./src/tests/ftest/tags.py lint --verbose
 
   flake8-lint:
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     name: Flake8 check
     steps:
       - name: Check out source repository
@@ -107,7 +107,7 @@ jobs:
 
   doxygen:
     name: Doxygen
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     steps:
       - name: Checkout code
         uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11  # v4.1.1
@@ -128,7 +128,7 @@ jobs:
 
   pylint:
     name: Pylint check
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     steps:
       - name: Checkout code
         uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11  # v4.1.1
@@ -148,7 +148,7 @@ jobs:
 
   codespell:
     name: Codespell
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     steps:
       - name: Checkout code
         uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11  # v4.1.1
@@ -163,7 +163,7 @@ jobs:
 
   linting-summary:
     name: Linting Summary
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     needs: [isort, shell-check, log-check, ftest-tags, flake8-lint, doxygen, pylint, codespell]
     if: (!cancelled())
     steps:

diff --git a/.github/workflows/pr-metadata.yml b/.github/workflows/pr-metadata.yml
@@ -13,7 +13,7 @@ permissions: {}
 
 jobs:
   example_comment_pr:
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     permissions:
       pull-requests: write
     name: Report Jira data to PR comment

diff --git a/.github/workflows/version-checks.yml b/.github/workflows/version-checks.yml
@@ -7,13 +7,14 @@ on:
   pull_request:
     paths:
       - 'utils/cq/requirements.txt'
+      - '.github/workflows/version-checks.yml'
 
 permissions: {}
 
 jobs:
   upgrade-check:
     name: Check for updates
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     strategy:
       fail-fast: false
       matrix:

diff --git a/ci/storage/test_main_storage_prepare_node.sh b/ci/storage/test_main_storage_prepare_node.sh
@@ -40,7 +40,7 @@ if ipmctl show -dimm; then
     ipmctl show -region
     find /dev -name 'pmem*'
 
-    daos_server scm $STORAGE_PREP_OPT --force
+    daos_server scm "$STORAGE_PREP_OPT"  --force
 
     if [ -n "$STORAGE_SCAN" ]; then
       # if we don't have pmem here, then we have a problem.

diff --git a/ci/unit/test_post_always.sh b/ci/unit/test_post_always.sh
@@ -37,7 +37,7 @@ case $STAGE_NAME in
 	;;
 esac
 
-mkdir -p $test_log_dir
+mkdir -p "$test_log_dir"
 
 rsync -v -rlpt -z -e "ssh $SSH_KEY_ARGS" jenkins@"$NODE":build/ .
 

diff --git a/src/tests/ftest/scripts/main.sh b/src/tests/ftest/scripts/main.sh
@@ -108,4 +108,4 @@ else
     rc=0
 fi
 
-exit $rc
+exit "$rc"
diff --git a/utils/scripts/helpers/install_maldet.sh b/utils/scripts/helpers/install_maldet.sh
@@ -34,7 +34,7 @@ printf "LogSyslog yes\n" >> /etc/clamd.d/scan.conf
 
 lmd_tarball='maldetect-current.tar.gz'
 : "${REPO_FILE_URL:=https://artifactory.dc.hpdd.intel.com/artifactory/repo-files/}"
-lmd_base_url="$(dirname $REPO_FILE_URL)"
+lmd_base_url="$(dirname "$REPO_FILE_URL")"
 lmd_base="${lmd_base_url#*://}"
 lmd_url="${lmd_base_url}/maldetect/downloads/${lmd_tarball}"
 curl "${lmd_url}" --silent --show-error --fail -o "/var/tmp/${lmd_tarball}"
-Original file line number
+Diff line change
@@ Expand Up / @@ -37,7 +37,7 @@ case $STAGE_NAME in @@
     	;;
     esac
-    mkdir -p $test_log_dir
+    mkdir -p "$test_log_dir"
     rsync -v -rlpt -z -e "ssh $SSH_KEY_ARGS" jenkins@"$NODE":build/ .
@@ Expand Down @@