-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Historic intersections #185
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@riordan @bertspaan thought you might enjoy this. Thanks so much for |
Hey Dan! Thanks for tagging me, this is great!!! So happy to see the datasets I published during my NYPL days are still useful! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds intersections from the NYPL's
nyc-streets.geojson
that don't exist in today's OSM. There are 1636 of these. Some of them are due to street renaming (4th Avenue → Park Avenue South) but many correspond to intersections that existed when the Milstein photos were taken but no longer exist today (example: Tompkins & Broome).This significantly reduces the need to interpolate and extrapolate existing streets (see #179 and #106 and this blog post).
We pick up a bunch of new items (401) and a bunch of others move (450). The moves are almost exclusively wins, but some are not. For example, 717831f has a title of "Broadway - 9th Avenue". Formerly this was unambiguous and near 220th street. But historically this was also an intersection around 65th Street. Other information on the photo makes it clear that 220th is the correct location.
The additions all seem fine. I'm excited to see that we're picking up some intersections along the erstwhile 13th Avenue!
Here are a few before/after GIFs:
Lower East Side, where housing projects and highways totally changed the grid:
Downtown Brooklyn, where the BQE and expanded Brooklyn Bridge onramp changed the grid:
Lower Manhattan, showing a very satisfying "filling in" of the map:
Data update: oldnyc/oldnyc.github.io@16b5b51