Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fill in README and add tests for main.ts #14

Merged
merged 9 commits into from
Jan 14, 2024
Merged

Conversation

danvk
Copy link
Owner

@danvk danvk commented Jan 14, 2024

This fills in usage for this repo (rather than the create-typescript-app template) and adds some tests for main.ts. I feel like there must be a more canonical way to mock the console methods for all tests in a group.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide. We are closing this pull request for now but you can update the pull request description and reopen the pull request.
The check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Copy link

codecov bot commented Jan 14, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d39a37d) 88.68% compared to head (b3a34f6) 94.70%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/main.ts 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
+ Coverage   88.68%   94.70%   +6.02%     
==========================================
  Files           9        9              
  Lines         716      718       +2     
  Branches       96      105       +9     
==========================================
+ Hits          635      680      +45     
+ Misses         80       37      -43     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danvk danvk merged commit 752f86e into main Jan 14, 2024
12 checks passed
@danvk danvk deleted the readme-main-tests branch January 14, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant