Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VERSION in Makefile and update documentation for string_view_t #3

Closed
wants to merge 4 commits into from

Conversation

dantargz
Copy link
Owner

@dantargz dantargz commented Oct 26, 2024

Add information to the docs about string_view_t and the overloads that use it.

Document generation was accidentally broken in previous commit from adding the word "version"

% make docs/manual.html   
asciidoctor -b html5 -a version=1.14 of pugixml this macro will become obsolete. docs/manual.adoc -o docs/manual.html
asciidoctor: FAILED: input file of is missing
make: *** [docs/manual.html] Error 1

The result of the old sed command:

% sed -n 's/.*version \(.*\).*/\1/p' src/pugiconfig.hpp 
1.14
of pugixml this macro will become obsolete.

Tweaked the sed command to /q quit after the first occurance of the word "version" -- my sed knowledge is weak, there may be a better way to do this.

@dantargz dantargz changed the title Update documentations for string_view_t overloads Fix VERSION in Makefile and update documentation for string_view_t Oct 26, 2024
@dantargz dantargz closed this Oct 28, 2024
@dantargz dantargz deleted the issue-626-documentation branch October 28, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants