Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker compose validation error #300

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

spaceo
Copy link
Collaborator

@spaceo spaceo commented Apr 14, 2023

Make shure we have unique yaml keys.
Inspired by this post:
docker/compose#10411 (comment)

Make shure we have unique yaml keys.
Inspired by this post:
docker/compose#10411 (comment)
@github-actions github-actions bot temporarily deployed to pr-300 April 14, 2023 12:48 Inactive
Copy link
Contributor

@kasperg kasperg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

I expect this is referred to errors seen in e.g. #299.

Since the problems originate in the setup provided by Lagoon you could consider also mentioning the problem and potentially providing a fix in there: https://github.com/lagoon-examples/drupal9-base/blob/main/docker-compose.yml.

In general I do not like problems such as this occurring unrelated to our code changes. I cannot see how we could do anything different here. As I understand it a fixed ubuntu-22.04 runner would suffer from the same problem.

@cableman cableman merged commit ee543e8 into develop Apr 17, 2023
@cableman cableman deleted the fix-docker-compose-validation-errors branch April 17, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants