The default seems to be BuildTools_ instead of Secret_ #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As mentioned in this issue dansiegel#272 the default in the code is BuildTools_ and not Secret_ as in Mobile Builds tools version 1.x
dansiegel
approved these changes
Mar 19, 2022
|
@dansiegel maybe it's good to also add Secret_ as an alias to BuildTools_ because everybody that upgrades from v1 to v2 will run into this problem I think. |
|
It was changed because some agents like Azure DevOps / AppCenter Windows build agents actually prevent variables with the prefix Secret_ from being read. They also do a ToUpper() which was a major reason why the definitions were added to the config. |
|
I understand. Good to know the reason behind the chance. Thanks for the explanation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in this issue #272 the default in the code is BuildTools_ and not Secret_ as in Mobile Builds tools version 1.x