Fix picotool to work with p8 carts that use CRLF line endings #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hout changing line endings
1. Fix the header parsing and GFX section parsing to not fail when lines end in CRLF 2. Clarify the invalid header failures between version failures and other types 3. add a specific test for CRLF carts
scottnm
commented
Jun 2, 2022
| @@ -1,5 +1,7 @@ | |||
| # picotool: Tools and Python libraries for manipulating PICO-8 game files | |||
|
|
|||
| [](https://github.com/scottnm/picotool/actions/workflows/python-app.yml) | |||
There was a problem hiding this comment.
oops. I probably need to fix this to point to this repo's test button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
picotool fails to read p8 carts which use CRLF line endings
this generally isn't a huge issue but git and windows make for really annoying problems dealing with line endings and given pico8 supports carts with CRLF line endings, it seems like a nice convenience for picotool to support both as well
this change...