Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 refactor: Use Undici Instead of Node-Fetch, prevent Event Close, add Index #3052

Merged
merged 3 commits into from
Jun 13, 2024
Merged

🚀 refactor: Use Undici Instead of Node-Fetch, prevent Event Close, add Index #3052

merged 3 commits into from
Jun 13, 2024

Conversation

danny-avila
Copy link
Owner

Summary

I implemented several changes to enhance the efficiency and performance of the application.

  • Refactored to use Undici instead of node-fetch in non-Bun environments for improved performance.
  • Refactored event handling to prevent immediate event closure on error, enhancing error management.
  • Added an index to the conversationId field in messageSchema to optimize database queries.

Change Type

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • I have made pertinent documentation changes
  • My changes do not introduce new warnings
  • I have written tests demonstrating that my changes are effective or that my feature works
  • Local unit tests pass with my changes

@danny-avila danny-avila merged commit 4416f69 into main Jun 13, 2024
4 checks passed
@danny-avila danny-avila deleted the chores-2024-06-13 branch June 13, 2024 17:38
danny-avila added a commit that referenced this pull request Aug 5, 2024
@danny-avila
🚀 refactor: Use Undici Instead of Node-Fetch, prevent Event Close, ad…
294bf6a 
…d Index (#3052)

* feat: Add index to conversationId field in messageSchema

* refactor: prevent immediate event close on error

* refactor: use undici instead of node-fetch in non-Bun environment
kenshinsamue pushed a commit to intelequia/LibreChat that referenced this pull request Sep 17, 2024
@danny-avila
🚀 refactor: Use Undici Instead of Node-Fetch, prevent Event Close, ad…
d8689f6 
…d Index (danny-avila#3052)

* feat: Add index to conversationId field in messageSchema

* refactor: prevent immediate event close on error

* refactor: use undici instead of node-fetch in non-Bun environment
BertKiv pushed a commit to BertKiv/LibreChat that referenced this pull request Dec 10, 2024
@danny-avila
🚀 refactor: Use Undici Instead of Node-Fetch, prevent Event Close, ad…
5ef9187 
…d Index (danny-avila#3052)

* feat: Add index to conversationId field in messageSchema

* refactor: prevent immediate event close on error

* refactor: use undici instead of node-fetch in non-Bun environment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: Use HTTP 2.0 for OpenAI requests
1 participant
@danny-avila