feature/introducing-composer #83
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This request introduces composer to the project. Composer can be used for dependency management and auto loading. Composer is the common best practice tool for PHP applications and would provide i.m.h.o a lot of benefits for this project especially if more features are planned in the future.
In this step I implemented composer for auto loading and moved the "HA-config file loading"-logic to a separate class for a more cleared structure of the code. The idea is to do this with other parts of the code as well to make feature implementations and application maintenance more easy.
Different to other PHP applications I decided to also commit the vendor directory. That's because I want to keep an installable artifact without touching any build process. Normally this directory is not included in the code, and built during the pipeline run when creating the artifact.
If you like my approach/Idea, I would really appreciate a merge into master, or if not, feel free to share your opinion with me.
Cheers Patrick