-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Importing stl throws error #11
Comments
Hi @comwizz2, I guess I'm opinionated about the jscad importer. I should add this to the readme. My belief is that it should just be plain Node.js and there is a lot of code in the importer that duplicates what already exists and is supported by a much larger community. Also, the importer would probably break the debugging capabilities of jscad-now since it uses a web worker in an opaque way. Thank for filing the issue though. If there are others who feel strongly that this should be added perhaps there is a Browserify plugin that we can write to achieve this functionality. |
Well some instructions on importing non-js files would be useful otherwise
I think.
If this is loading in the browser can I even require the file api?
…On Tue, May 18, 2021 at 4:23 PM Dan Marshall ***@***.***> wrote:
Hi @comwizz2 <https://github.com/comwizz2>, I guess I'm opinionated about
the jscad importer. I should add this to the readme.
My belief is that it should just be plain Node.js and there is a lot of
code in the importer that duplicates what already exists and is supported
by a much larger community. Also, the importer would probably break the
debugging capabilities of jscad-now since it uses a web worker in an opaque
way.
Thank for filing the issue though. If there are others who feel strongly
that this should be added perhaps there is a Browserify plugin that we can
write to achieve this functionality.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#11 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABMJ27V5J5KBWEGP5B6B23DTOLLFLANCNFSM443IZZPQ>
.
|
I think that you can just use the Node.js file api, and that Browserify will make it "just work" in the browser. |
Trying to import an STL using require throws a parser error. I believe this means it is not trying to use the jscad importer, but instead import it as a js module. This project works perfectly fine when drug into the the jscad site for 2.0.
The text was updated successfully, but these errors were encountered: