Fix undefined array key "text" on IOMAD Moodle installations #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dealing with an error saving configuration on IOMAD Moodle. should not cause any issues with other installations, but did not test on vanilla Moodle installation.
Update locallib.php
|
Thanks for the PR - I'm not clear why you've changed key_exists to array_key_exists? - personally I prefer the shorter version. Also - it's triggering moodle check failures due to the extra spaces on the line endings of some of the lines in your patch? - I'm happy to merge something like this in, but it would be easier for me if it only changed the required lines (and didn't trip the coding check failures.) thanks! |
|
no problem.. to be honest I didn't realize I left that in. I'll double check it.. I quite honestly suck with github so this is pretty new to me. |
|
Thanks, i dropped in a fix for the spacing issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning: Undefined array key "text" in /var/www/vhosts/sandbox.domain.ca/iomad/local/recompletion/locallib.php on line 102
Have not tested on vanilla Moodle installations, but can't see any reason why it would cause issues.