valueflow.cpp: reduced some variable scopes/lifetimes #7076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lues()` until necessary
|
This highlights some cases we could report via |
firewave
changed the title
chrchr-github
changed the title
danmar
approved these changes
Dec 6, 2024
| @@ -3699,8 +3699,11 @@ static void valueFlowSymbolicInfer(const SymbolDatabase& symboldatabase, const S | |||
| if (astIsFloat(tok->astOperand2(), false)) | |||
| continue; | |||
|
|
|||
| SymbolicInferModel leftModel{tok->astOperand1()}; | |||
| std::vector<ValueFlow::Value> values = infer(leftModel, tok->str(), 0, tok->astOperand2()->values()); | |||
| std::vector<ValueFlow::Value> values; | |||
There was a problem hiding this comment.
I don't an opinion but we could also write:
std::vector<ValueFlow::Value> values = [tok](){
SymbolicInferModel leftModel{tok->astOperand1()};
return infer(leftModel, tok->str(), 0, tok->astOperand2()->values());
}();
Use the syntax you like..
There was a problem hiding this comment.
I do not find that more readable. I am also not sure fi that might introduce some overhead.
I mainly changed this because I was debugging the lifetime of the infer models at some point and was confused that two of them were alive at the same time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.