Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

googletest: add TYPED_TEST macros #7071

Merged
merged 1 commit into from
Dec 6, 2024
Merged

googletest: add TYPED_TEST macros #7071

merged 1 commit into from
Dec 6, 2024

Conversation

fwinkl
Copy link
Contributor

@fwinkl fwinkl commented Dec 4, 2024

Add TYPED_TEST and TYPED_TEST_P macro definitions (see http://google.github.io/googletest/reference/testing.html).

@danmar
Copy link
Owner

danmar commented Dec 5, 2024

Thanks! What problem did you see because these macros was missing? Could you add a minimal test code to test/cfg/googletest.cpp to ensure there will not be regressions later.

Add `TYPED_TEST` and `TYPED_TEST_P` macro definitions.
@fwinkl
Copy link
Contributor Author

fwinkl commented Dec 5, 2024

I added a test-case (only happens within a namespace). Btw, the googletest.cpp doesn't really run cleanly anymore and shows many unmatchedSuppression even before my changes.

@danmar danmar merged commit c27c13b into danmar:main Dec 6, 2024
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants