Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #13344 (Tokenizer: Do not remove extra parentheses ((..))) #7036

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Fix #13344 (Tokenizer: Do not remove extra parentheses ((..))) #7036

merged 1 commit into from
Dec 6, 2024

Conversation

swasti16
Copy link
Contributor

No description provided.

danmar
danmar approved these changes Nov 25, 2024
View reviewed changes
Copy link
Owner

@danmar danmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. I just want that we test it with test-my-pr.py before we merge..

@danmar danmar changed the title Add both the parenthesis in tokenlist for ((x)) Fix #13344 (Tokenizer: Do not remove extra parentheses ((..))) Nov 25, 2024
@danmar
Copy link
Owner

danmar commented Dec 6, 2024

It looks good to me. I just want that we test it with test-my-pr.py before we merge..

I ran tests over night and it looks good.

I only saw some problems related to our AST so I created https://trac.cppcheck.net/ticket/13381 about that.

@danmar danmar merged commit 57d4d61 into danmar:main Dec 6, 2024
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danmar danmar danmar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swasti16 @danmar