Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #13302 false negative: noConstructor (regression) #7001

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Fix #13302 false negative: noConstructor (regression) #7001

merged 2 commits into from
Dec 4, 2024

Conversation

chrchr-github
Copy link
Collaborator

No description provided.

danmar
danmar approved these changes Nov 20, 2024
View reviewed changes
Copy link
Owner

@danmar danmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chrchr-github
Copy link
Collaborator Author

Thanks for the approval. How about that daca update though?

@danmar
Copy link
Owner

danmar commented Dec 4, 2024

Thanks for the approval. How about that daca update though?

oh.. I have updated the server now. Thanks for reminding me!

@chrchr-github
Copy link
Collaborator Author

Thanks for the approval. How about that daca update though?

oh.. I have updated the server now. Thanks for reminding me!

Cool 👍
And I already see a crash that hasn't been fixed yet...

@chrchr-github chrchr-github merged commit 152dd9d into danmar:main Dec 4, 2024
60 checks passed
@chrchr-github chrchr-github deleted the chr_13302 branch December 4, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danmar danmar danmar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrchr-github @danmar