fixed #12348 - fixed missing analyzer information for markup files #6952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firewave
commented
Oct 25, 2024
lib/cppcheck.cpp
Outdated
| // TODO: set analyzer information | ||
|
|
||
| // TODO: how to get the proper tokenlist to generate the proper hash? | ||
| const std::size_t hash = time(nullptr); // calculateHash(tokenizer.list, mSettings); |
There was a problem hiding this comment.
This requires a simplecpp::TokenList which we do not create in this context.
This is a hack so the hash is different every time.
There was a problem hiding this comment.
The Preprocessor::calculateHash is pretty simple it should be possible to write a similar function that uses tokenizer.list.. as shown in the comment?
There was a problem hiding this comment.
I can have a look.
There was a problem hiding this comment.
I now generate a hash from the proper inputs.
firewave
force-pushed
the
unused-xx
branch
2 times, most recently
from
178381c to
ee3d733
Compare
danmar
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.