-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fail some build steps if changed or unversioned files exist at the end / several related cleanups and adjustments #6787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to expose tests (or other commands) which generate (and leave) files in the source tree. Files which are being ignored should not fail this. This should primarily be fixed by using temporary folders. In case this can't be done we need to make sure they are cleaned up - and in some cases we might also need to clean previously existing files beforehand. |
firewave
changed the title
CI-unixish.yml: fail
CI-unixish.yml: fail Sep 9, 2024
build
step if unversioned files exists at the endbuild
step if unversioned files exist at the end
This comment was marked as resolved.
This comment was marked as resolved.
firewave
force-pushed
the
uknown-files
branch
from
October 30, 2024 13:32
b9f6f5f
to
b9861ed
Compare
|
firewave
changed the title
CI-unixish.yml: fail
CI-unixish.yml: fail Oct 30, 2024
build
step if unversioned files exist at the endbuild
step if changed and unversioned files exist at the end
firewave
force-pushed
the
uknown-files
branch
from
October 30, 2024 13:56
b9861ed
to
ddfc6c0
Compare
firewave
changed the title
CI-unixish.yml: fail
CI-unixish.yml: fail Oct 30, 2024
build
step if changed and unversioned files exist at the endbuild
step if changed or unversioned files exist at the end
firewave
force-pushed
the
uknown-files
branch
from
November 1, 2024 15:14
ddfc6c0
to
7defac7
Compare
firewave
force-pushed
the
uknown-files
branch
from
December 2, 2024 08:22
2cd903d
to
9bbd46c
Compare
firewave
changed the title
CI-unixish.yml: fail
CI-unixish.yml: fail Dec 2, 2024
build
step if changed or unversioned files exist at the endbuild
step if changed or unversioned files exist at the end / several related cleanups and adjustments
firewave
changed the title
CI-unixish.yml: fail
fail some build steps if changed or unversioned files exist at the end / several related cleanups and adjustments
Dec 2, 2024
build
step if changed or unversioned files exist at the end / several related cleanups and adjustments
firewave
force-pushed
the
uknown-files
branch
3 times, most recently
from
December 2, 2024 15:12
789f711
to
2c5873e
Compare
firewave
force-pushed
the
uknown-files
branch
2 times, most recently
from
December 11, 2024 19:03
035f2ae
to
d35a9bc
Compare
firewave
force-pushed
the
uknown-files
branch
2 times, most recently
from
December 13, 2024 11:44
2c0a49f
to
0cc1a98
Compare
danmar
approved these changes
Dec 15, 2024
…pfile.mkdtemp()` for automatic cleanup
…iles exist afterwards
firewave
force-pushed
the
uknown-files
branch
from
December 15, 2024 17:53
b81c78d
to
e587595
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.