Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disabled some clang-tidy checks which are not necessary and slow down the analysis / documented disabled checks #4468

Merged
merged 2 commits into from
Sep 16, 2022

Conversation

firewave
Copy link
Collaborator

See llvm/llvm-project#57527 (comment) for details on the slowdown from clang-tidy-14 to clang-tidy-15 as well as data on the most expensive checks.

@firewave
Copy link
Collaborator Author

We might be able to disable the extremely expensive misc-confusable-identifiers check as well since it is covered by the -Wbidi-chars GCC compiler warning which is enabled by default - see https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html. So the additional static analysis might not be necessary at all.

@firewave firewave mentioned this pull request Sep 15, 2022
@orbitcowboy orbitcowboy merged commit 888721e into danmar:main Sep 16, 2022
@firewave firewave deleted the tidy branch September 16, 2022 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants