Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inline to a few places #12

Merged
merged 1 commit into from
Apr 27, 2023
Merged

Conversation

hecatia-elegua
Copy link
Collaborator

where else would it make sense?

@danlehmann
Copy link
Owner

Did you ever see any difference with these? Not against it, just curious

@hecatia-elegua
Copy link
Collaborator Author

Since I'm using the From impls, it didn't inline those calls across the crate boundary into the code generated by bilge.
This solved it. The other impls are just a line of code, so I added it there as well, I just left out the math ops :)

@danlehmann danlehmann merged commit ce9c1b0 into danlehmann:main Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants