Addressed: sign extension issue found by Coverity #21

dankogai · Apr 29, 2014 · 138d4a9 · 138d4a9
1 parent 2df5baa
commit 138d4a9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/Changes b/Changes
@@ -3,6 +3,9 @@
 # $Id: Changes,v 2.59 2014/04/06 17:23:55 dankogai Exp $
 #
 $Revision: 2.59 $ $Date: 2014/04/06 17:23:55 $
+! Unicode/Unicode.xs
+  Addressed: sign extension issue found by Coverity #21
+  https://github.com/dankogai/p5-encode/issues/21
 ! Encode/encode.h Encode.xs Unicode/Unicode.xs
   removed #define U8 U8
   https://rt.perl.org/Ticket/Display.html?id=121554

diff --git a/Unicode/Unicode.xs b/Unicode/Unicode.xs
@@ -79,7 +79,7 @@ enc_unpack(pTHX_ U8 **sp, U8 *e, STRLEN size, U8 endian)
 	if (endian == 'v')
 	    break;
 	v |= (*s++ << 16);
-	v |= (*s++ << 24);
+	v |= ((UV)*s++ << 24);
 	break;
     default:
 	croak("Unknown endian %c",(char) endian);