Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eliminate recursion in ncplane_polyfill_yx() #2328

Closed
dankamongmen opened this issue Nov 7, 2021 · 2 comments · Fixed by #2331
Closed

eliminate recursion in ncplane_polyfill_yx() #2328

dankamongmen opened this issue Nov 7, 2021 · 2 comments · Fixed by #2331
Assignees
@dankamongmen
Labels
bug Something isn't working
Milestone
3.0.0

Comments

@dankamongmen
Copy link
Owner

We earlier found ncvisual_polyfill_yx() to be blowing up due to recursing too deep. I'd forgotten all about ncplane_polyfill_yx()'s existence. It has the same issue. Clean it up. Make sure there's a unit test or two on it, also.
@dankamongmen dankamongmen added the bug Something isn't working label Nov 7, 2021
@dankamongmen dankamongmen added this to the 3.0.0 milestone Nov 7, 2021
@dankamongmen dankamongmen self-assigned this Nov 7, 2021
@dankamongmen
Copy link
Owner Author

it also needs diagnostics.

dankamongmen added a commit that referenced this issue Nov 7, 2021
@dankamongmen
eliminate recursion in ncplane_polyfill_yx #2328
61f6407
@dankamongmen
Copy link
Owner Author

resolved in the dankamongmen/negativecursor branch

@dankamongmen dankamongmen linked a pull request Nov 7, 2021 that will close this issue
Standardized geometries and unsigned dimensions #2331
Merged
dankamongmen added a commit that referenced this issue Nov 7, 2021
@dankamongmen
eliminate recursion in ncplane_polyfill_yx #2328
2820f7a
dankamongmen added a commit that referenced this issue Nov 9, 2021
@dankamongmen
eliminate recursion in ncplane_polyfill_yx #2328
0472e5c
dankamongmen added a commit that referenced this issue Nov 9, 2021
@dankamongmen
eliminate recursion in ncplane_polyfill_yx #2328
91420af
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dankamongmen dankamongmen

Labels
bug Something isn't working
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Standardized geometries and unsigned dimensions dankamongmen/notcurses
1 participant
@dankamongmen