Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coordinate arguments ought always accept -1 as "current cursor" #2324

Closed
dankamongmen opened this issue Nov 5, 2021 · 0 comments · Fixed by #2331
Closed

coordinate arguments ought always accept -1 as "current cursor" #2324

dankamongmen opened this issue Nov 5, 2021 · 0 comments · Fixed by #2331
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Milestone

Comments

@dankamongmen
Copy link
Owner

See PR #2320 and issue #1696. We changed all length and coordinate arguments to unsigned for the listed functions. There are many other functions, however, which accept "-1" for any coordinate, meaning "current cursor position in the relevant dimension". This is a useful technique to have available, and we certainly must maintain it where already present.

Indeed, this ought be the global semantic for coordinates. So on the affected functions, change those coordinate params back to int from unsigned, and implement the "-1" case everywhere. Lengths remain unsigned; that's fine. This change never got released, so it's not a big deal user-wise (and it ought hew more closely to the current ABI, which i was admittedly a bit sloppy about in #2320).

Don't cut 2.4.9 until this is done.

@dankamongmen dankamongmen added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 5, 2021
@dankamongmen dankamongmen added this to the 3.0.0 milestone Nov 5, 2021
@dankamongmen dankamongmen self-assigned this Nov 5, 2021
dankamongmen added a commit that referenced this issue Nov 7, 2021
dankamongmen added a commit that referenced this issue Nov 7, 2021
@dankamongmen dankamongmen linked a pull request Nov 7, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant