Bring back sleeping code for periodic frame timing #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out relying on
-reto provide periodic frame output is wrong, as I learned the hard way. This PR reintroduces the sleeping code for periodic frame output, which also involves getting backpressure to work so that memory leaks don't happen.The mechanism for this is pretty simple. Frames are repeatedly extracted from the input stream until either the video or audio pipe reaches
highWaterMark, after which we pause the input stream. When the pipe has been drained, we resume the input stream and continue extraction.Unfortunately, this only partially fixes #115, something in the video file is causing consistent 5+ seconds pauses, that doesn't happen with other files that I've tested. Will continue to investigate. For now please give this a try.