Skip to content

Commit

Permalink
lib/x11utils: ensure_unlocked_desktop: Don't wait until xscreensaver …
Browse files Browse the repository at this point in the history
…disappears

Previously it pressed a key to "update the screen" and then did a
wait_still_screen which timed out because of the animated xscreensaver prompt.
That caused the prompt to disappear again before it entered the password.

Ideally the second wait_still_screen gets removed, but to avoid introducing
some regression somewhere the timeout is halved instead.
  • Loading branch information
Vogtinator committed Mar 8, 2023
1 parent bfb5959 commit 44cec24
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lib/x11utils.pm
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,9 @@ sub ensure_unlocked_desktop {

# press key to update screen, wait shortly before and after to not match cached screen
my $wait_time = get_var('UPGRADE') ? 10 : 3;
wait_still_screen($wait_time);
wait_still_screen($wait_time, timeout => 15);
send_key 'ctrl';
wait_still_screen($wait_time);
wait_still_screen($wait_time, timeout => 15);
while ($counter--) {
my @tags = qw(displaymanager displaymanager-password-prompt generic-desktop screenlock screenlock-password authentication-required-user-settings authentication-required-modify-system guest-disabled-display oh-no-something-has-gone-wrong);
push(@tags, 'blackscreen') if get_var("DESKTOP") =~ /minimalx|xfce/; # Only xscreensaver and xfce have a blackscreen as screenlock
Expand Down

0 comments on commit 44cec24

Please sign in to comment.