Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set all counter values to zero on start #72

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

hiaselhans
Copy link
Contributor

Thanks for this exporter!

this PR solves #47

it goes through all counters and increases the not-matched counters by zero so they are populated with the corresponding labels and an unchanged value (0 if unset).

to make celery-exporter work i had to remove the git-dependency to celery.
That solves #71
Is the "allow-heartbeats-in-tests" used somewhere?

and then there is this: pallets/markupsafe#282
so i pinned the version in pyproject.toml

- increase unaffected counters by zero to populate them
- update dependencies
@danihodovic danihodovic changed the title populate unaffected counters Set all counter values to zero on start Feb 23, 2022
@danihodovic
Copy link
Owner

Is the "allow-heartbeats-in-tests" used somewhere?

It was a branch I made to Celery so that we can test heartbeats. It was merged here celery/celery#6632

Thank you for the contribution Simon

@danihodovic danihodovic merged commit e67c1f1 into danihodovic:master Feb 23, 2022
@hiaselhans
Copy link
Contributor Author

wow, thanks for the fast response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants