Update to project to support Nullable types

[ndrwrbgs]

No description provided.

[ndrwrbgs]

Fixes #154

I cannot enumerate the implications that changing return value annotations of [NotNull] to [return: NotNull] may have, particularly for folks on older versions or analyzers.

I also cannot be sure that NuGet won't complain about a class existing under the System namespace. I know they check for that, but I'm not sure if they care about internal classes.

[danielwertheim]

@ndrwrbgs Nice work. We could publish it as a preview and evaluate, just let me know when you believe it's ready and if I could assist with anything.

[ndrwrbgs]

Any chance I could get you to move the file? I won't be able to get back to this this week

[danielwertheim]

@ndrwrbgs are there anything more left on this PR? Should I merge it in and put out a new release? I left one comment above.

[danielwertheim]

Given your comment regarding old analyzer compatibility etc, should this then be a major bump?

[ndrwrbgs]

I'm genuinely not sure. Even academically speaking, Attributes are in a bit of a gray zone. Are they metadata, or are they contract -- it depends how folks use them. I could buy an argument for either way. I don't think we'd have a super great "we had to bump to 11 because of..." but I also don't know how much a major version bump scares people/how adoption on new versions is.

…

On Tue, Mar 30, 2021 at 11:58 AM Daniel Wertheim ***@***.***> wrote: Given your comment regarding old analyzer compatibility etc, should this then be a major bump? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#155 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACSHCOTWHLXK2CELOROOUSTTGINPHANCNFSM4Y43WMTQ> .

[danielwertheim]

OK. Let me know when I should merge.

[ndrwrbgs]

Good to go

…

On Tue, Mar 30, 2021, 12:08 PM Daniel Wertheim ***@***.***> wrote: OK. Let me know when I should merge. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#155 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACSHCOUIMT63U7XZGGSAT33TGIOTJANCNFSM4Y43WMTQ> .