Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IsAllLettersOrDigits method for strings #144

Merged
merged 5 commits into from
Jun 7, 2020
Merged

Add IsAllLettersOrDigits method for strings #144

merged 5 commits into from
Jun 7, 2020

Conversation

pBouillon
Copy link
Contributor

Add the IsAllLettersOrDigits method according to this comment in #141

This method checks if all chars of a string is either a letter or a digit and raise an ArgumentException if not

I tried to be consistent with the existing code base, I can modify whatever I may have missed !

danielwertheim
danielwertheim reviewed Jun 6, 2020
View reviewed changes
Copy link
Owner

@danielwertheim danielwertheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution,

Looks good. Found some missing attributes and the ToCharArray thing that I'm thinking it perhaps should be replaced.

src/projects/EnsureThat/Enforcers/StringArg.cs Outdated Show resolved Hide resolved
src/projects/EnsureThat/Enforcers/StringArg.cs Show resolved Hide resolved
src/projects/EnsureThat/EnsureArg.Strings.cs Show resolved Hide resolved
@danielwertheim danielwertheim linked an issue Jun 6, 2020 that may be closed by this pull request
Add the ability to check that a string is made up of a certain type of character(s) #141
Closed
@danielwertheim danielwertheim merged commit 8e0883b into danielwertheim:master Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielwertheim danielwertheim danielwertheim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the ability to check that a string is made up of a certain type of character(s)
2 participants
@pBouillon @danielwertheim