Adds HasValue #142
Adds HasValue #142
Conversation
|
@ndrwrbgs added experimental support as a new member in PR. Haven't tested performance, allocations etc. Naming. Not sure. Wrestled a bit between |
| [ContractAnnotation("value:null => halt")] | ||
| public T HasValue<T>([NoEnumeration, ValidatedNotNull] T value, [InvokerParameterName] string paramName = null, OptsFn optsFn = null) => value switch | ||
| { | ||
| ValueType _ => value, |
There was a problem hiding this comment.
Looks like ValueType != struct - this syntax is new to me so I can only cursorily look over it, since I would've expected int? (I think Nullable is a struct?) to be ValueType, but your tests show that must not be true
After measuring the boxing path was more performant (both time and alloc)
There was a problem hiding this comment.
I've heard rumors JIT might be able to optimize away a ReferenceEquals(null) (so maybe an == too? Though that can be overridden whereas Reference can't) -- I'm curious if the call can be inlined and removed for a generic that happens to be a ValueType, but it's not really important enough to suggest any changes. Either it is and users rejoice, or it's not and there's nothing more to be done than what you already supplied as warning in the xmldoc comment ;)
Resolves #140 by adding
HasValuethat supports value types and reference types.