Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for .NET 4.5.1 and .NET Standard 1.1 #159

Closed
danielwertheim opened this issue Jul 6, 2021 · 5 comments · Fixed by #162, #166 or #170
Closed

Drop support for .NET 4.5.1 and .NET Standard 1.1 #159

danielwertheim opened this issue Jul 6, 2021 · 5 comments · Fixed by #162, #166 or #170
Labels
Breaking Improvement
Milestone
v11

Comments

@danielwertheim
Copy link
Owner

Line: https://github.com/danielwertheim/Ensure.That/blob/master/src/projects/EnsureThat/EnsureThat.csproj#L4
@danielwertheim
Copy link
Owner Author

@ndrwrbgs what are your thoughts on this?

@danielwertheim danielwertheim mentioned this issue Jul 6, 2021
Closed
@danielwertheim danielwertheim changed the title Drop explicit support for .NET 4.5.1 and rely on .NET Standard 1.1? Drop support for .NET 4.5.1, and .NET Standard 1.1 Oct 11, 2021
@danielwertheim danielwertheim changed the title Drop support for .NET 4.5.1, and .NET Standard 1.1 Drop support for .NET 4.5.1 and .NET Standard 1.1 Oct 11, 2021
danielwertheim added a commit that referenced this issue Oct 11, 2021
@danielwertheim
Fixes #159, Only supports netstandard2.0 and netstandard2.1
faf6ba5
@danielwertheim danielwertheim mentioned this issue Oct 11, 2021
Merged
@danielwertheim danielwertheim added this to the v11 milestone Oct 11, 2021
danielwertheim added a commit that referenced this issue Oct 18, 2021
@danielwertheim
Next (#162)
87adc5e 
* Fixes #159, Only supports netstandard2.0 and netstandard2.1

* Fixes #161

* Changes EnsureOptions to be readonly

* Change so that Ensure.That returns the Param

* NuGet upgrades

* Fixes benchmark

* Docs
@ndrwrbgs
Copy link
Contributor

Apologies for my absence! My thoughts are mostly :( since we're stuck on 4.6.2 at work, and that has broken .NET Standard libraries support - but if we (Ensure.That) aren't pulling in other libraries then I think it should work okay?

@danielwertheim
Copy link
Owner Author

Some good writing to why explicit old .NET support should be kept in: https://weblog.west-wind.com/posts/2019/Feb/19/Using-NET-Standard-with-Full-Framework-NET

@danielwertheim
Copy link
Owner Author

Reducing to 4.6.2 from 4.5.1

danielwertheim added a commit that referenced this issue Oct 27, 2021
@danielwertheim
Fixes #159 and brings explicit support for .NET4.6.2
a0486f5
@danielwertheim danielwertheim linked a pull request Oct 27, 2021 that will close this issue
Fixes #159 and brings explicit support for .NET4.6.2 #166
Merged
danielwertheim added a commit that referenced this issue Oct 27, 2021
@danielwertheim
Fixes #159 and brings explicit support for .NET4.6.2 (#166)
3312a4c
@danielwertheim danielwertheim linked a pull request Jan 15, 2022 that will close this issue
Final decision. Support two latest LTS and oldie 4.6.2 #170
Merged
@danielwertheim
Copy link
Owner Author

Will keep two latest LTS .NET6 and 3.1 and oldie 4.6.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Breaking Improvement
Projects
None yet
Milestone
v11
2 participants
@danielwertheim @ndrwrbgs