Fixing issue #789 - File.writeFile was broken. #796
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this patch, `File.writeFile` has the `replace` and `append` options flipped; setting `replace: true` would block the file from being replaced, and setting `append: true` would always create a new file and never append.
|
Thoughts on this @ihadeed? I'm not fresh on File plugin knowledge |
|
This is fixed here: 867400d#diff-9c468d792814968d6a9ecd58630290cbR682 Your fork is outdated. Please try with the latest version of Ionic Native and report back if the issue still exists. @wwoods |
|
Just had a look at the issue you submitted here: #789 You're right it does need to be fixed. Please check my comment there and maybe submit a new PR to fix the latest repo code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this patch,
File.writeFilehas thereplaceandappendoptions flipped; setting
replace: truewould block the file from beingreplaced, and setting
append: truewould always create a new file andnever append.