feat(in-app-purchase-3) new InAppPurchase3 plugin #4849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gxolin
commented
Oct 10, 2024
| @Plugin({ | ||
| pluginName: 'InAppPurchase3', | ||
| plugin: 'cordova-plugin-purchase', | ||
| pluginRef: 'CdvPurchase.store', |
There was a problem hiding this comment.
other BC breaks aside, this is where the plugin was no more discovered by awesome-cordova despite beeing registered by capacitor :
cordova-plugin-purchase v11 was using window['store'], the v13 version is using window['CdvPurchase.store']
danielsogl
approved these changes
Oct 13, 2024
danielsogl
added a commit
that referenced
this pull request
Nov 11, 2024
This reverts commit be6000f.
danielsogl
added a commit
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #4848
I'm not sure if this should be an update of the plugin in-app-purchase-2, but since the wrapped cordova-plugin-purchase got some huge backward compatibility breaks in the version 13.x I thought it was better.
(Note : only lightly tested, I'm new to both capacitor and cordova-plugin-purchase. I'll test it more thoughtfully in the next days, I'm working on a angular + capacitor in app purchase integration.)