Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: accept own properties for addMarker() and others [google-maps] #2093

Merged
merged 94 commits into from
Nov 8, 2017
Merged

Add: accept own properties for addMarker() and others [google-maps] #2093

merged 94 commits into from
Nov 8, 2017

Conversation

wf9a5m75
Copy link
Contributor

@wf9a5m75 wf9a5m75 commented Nov 6, 2017

Add: accept own properties for addMarker() and others #2087

Fix: some properties are required, but specified as optional.

Add: descriptions for properties

add: BaseClass.destroy()
add: getId() method for all instance classes
…es()

Those methods need to create new instance of BaseArrayClass of wrapper plugin.
…Id() if the passed element is string

update: map.setDiv()

Bug fix: can not create empty GoogleMap (pure JS version is available way)
Fix: some properties are required, but specified as optional.

Add: descriptions for properties
@ihadeed ihadeed merged commit 196be02 into danielsogl:master Nov 8, 2017
@wf9a5m75
Copy link
Contributor Author

wf9a5m75 commented Nov 8, 2017

Thank you for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants