-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Device #954
Comments
That's happening because you're running on I should probably change that and make it return |
@ihadeed Yes I understand. I used to have a method to check if cordova wasn't available, that used to work perfectly before this change. I think it would be great to make it return an Thanks for the quick reply. |
This reverts part of commit 67adb23, which moved the call to getPlugin() from within CordovaProperty() to a point where it was called too early. When the CordovaProperty decorator is called on a property, the class containing that call has not yet had its Plugin decorator called. Only when the latter happens does pluginRef get set. Thus, attempting to access pluginRef within CordovaProperty at the time of the call will give undefined, and attemping to call getPlugin with an undefined value will throw an exception: Runtime Error Cannot read property 'split' of undefined TypeError: Cannot read property 'split' of undefined at get at getPlugin at CordovaProperty at __decorate ... The above message can be seen in the browser after running the 'ionic serve' command. This commit moves the getPlugin call back to the getters and setters established by CordovaProperty, which are only called *after* the Plugin decorator has finished executing. closes danielsogl#954
Im aware of the changes stated in 2.11.11 where Device.device.uuid becomes Device.uuid.
Problem description: When calling Device.uuid in the browser, instead of getting return undefined, I get an empty object. This happens since 2.11.11
Procedure:
Console.log(Device.uuid);
Expected Outcome:
Undefined
Experienced Outcome:
{}
The text was updated successfully, but these errors were encountered: