-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(media): fix issue with create method
closes #1333
- Loading branch information
Showing
1 changed file
with
1 addition
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6bba72d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I'm stuck with this issue in my project.
If I use version 3.5.0 of media plugin, which integrates this fix, my project doesn't work anymore (the Promise in create() is never resolved), if I force my project to use version 3.4.4 of media plugin (which doesn't contain this fix) everything works well.
What's the matter with this fix?
6bba72d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sertal70 sorry this fix was supposed to be reverted, please use an older version for now until I publish the next release (soon).
6bba72d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @ihadeed, actually I already pulled version 3.4.4 in my project to go forward... let me know when it will be definitively fixed.
6bba72d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be fixed in 3.6.1, but I haven't updated the docs yet.