Fix Router Push / Replace with URL Object #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@laooola Thank you for the PR! I'll try to get it merged within the next 2 days. |
|
@danielr18 I'd probably do a new major release as this change won't work for |
Right, it'll be documented in the top section of the readme. Similar to how it was done for v3.0.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered some issues with
Router.pushandRouter.replacein combination with url objects after updating to[email protected]. Turned out that the internal router api has been changed in9.5.0(see vercel/next.js#14827). This PR accounts for these changes.