Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixing Issue with Member Assignments in Consumer Group #429

Merged

Conversation

sciclon2
Copy link
Contributor

@sciclon2 sciclon2 commented Mar 14, 2024

PR Summary:

Title: Fixing Issue with Member Assignments in Consumer Group

Description: The code was updated to handle cases where consumer group members do not have any assigned partition-topic (for example in a rebalance). Previously, the code was expecting all assignments to have a value, leading to errors when encountering members without assignments. The fix involved checking if member.MemberAssignment is not an empty list before processing the assignment to ensure proper handling of all scenarios within the consumer group.

Example:

Previous Behavior:

  • Code expected all member assignments to have a value.
  • Errors occurred when encountering consumer group members with no assigned partition-topic.

Fix Implemented:

  • Updated code to check if member.MemberAssignment is not an empty list.
  • Ensured proper handling of cases where assignments are empty for consumer group members.

By incorporating this fix, the code now effectively manages scenarios where consumer group members may not have any assigned partition-topic, preventing errors and enhancing the overall functionality of the system.

@danielqsj
Copy link
Owner

LGTM, thanks @sciclon2

@danielqsj danielqsj merged commit 3b37dc8 into danielqsj:master Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants