Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider offering comma-separated arguments instead of semicolon separated #721

Closed
fgimian opened this issue Jan 21, 2025 · 5 comments
Closed

Comments

@fgimian
Copy link

fgimian commented Jan 21, 2025

Hey there, hope you're doing really well.

I find it a bit inconvenient that the reportgenerator CLI expects semicolon separated items for arguments such as -reporttypes. Semicolon is a special character in almost all shells which forces users to quote this argument when running the tool.

Would it be possible to at least offer the ability to comma separate these values as well?

e.g.

Instead of:

dotnet reportgenerator `
  -reports:src/**/coverage.cobertura.xml `
  -targetdir:.coverage `
  "-reporttypes:Cobertura;lcov;Html" `
  -filefilters:-*.g.cs

We would be able to do the following:

dotnet reportgenerator `
  -reports:src/**/coverage.cobertura.xml `
  -targetdir:.coverage `
  -reporttypes:Cobertura,lcov,Html `
  -filefilters:-*.g.cs

Thanks heaps
Fotis

@danielpalme
Copy link
Owner

Thanks for your suggestion.
I made the necessary changes in f778630

The next release will contain this change.

@fgimian
Copy link
Author

fgimian commented Jan 22, 2025

Thanks for your suggestion.
I made the necessary changes in f778630

The next release will contain this change.

Thank you so much!!

@kbell-tamu
Copy link

I'm using Azure DevOps and just encountered this issue as well when trying to build on a linux host. In addition to the above fix, I think a change is also needed to the code in the AzureDevOps task line 71 where it is splitting the report types to make sure an HTML report is added. There is also code on line 21 to split custom settings, but I haven't used that feature to know if it's a problem there. Thank you!

@danielpalme
Copy link
Owner

@kbell-tamu
Thanks for the hint! I will change it there too!

danielpalme added a commit that referenced this issue Feb 5, 2025
@danielpalme
Copy link
Owner

Release 5.4.4 is now available.
The AzureDevOps task has been updated as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants