fix: process template variables in raw input #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Process template variables ({{var}}) consistently in both pattern files
and raw input messages. Previously variables were only processed when
using pattern files.
- Add template variable processing for raw input in BuildSession
- Initialize messageContent explicitly
- Remove errantly committed build artifact (fabric binary in previous commit)
echo 'Hello {{name}}' | ./fabric -v=noname:World
missing required variable: name
…ed in pattern streamlined some context staging
1 task
|
@mattjoyce Please provide a way to turn off this new behavior (preferably make it so you have to turn it on with a new flag, like It's a great feature, but it breaks existing workflows where you're feeding files (or snippets of files, like diffs) that use Go templates or Jinja2 format; e.g Ansible Playbooks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Process template variables ({{var}}) consistently in both pattern files and raw input messages. Previously variables were only processed when using pattern files.
This will now support inline macros, with missing var checks.
echo 'Hello {{name}}' | ./fabric -v=name:World