Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and extend German word list #492

Merged
merged 1 commit into from
Sep 16, 2020

Conversation

drwetter
Copy link
Contributor

This is a complete replacement of lang-german.txt. As mentioned before the list was in wrong format (7 Bit) and couldn't reflect the German Umlaute at all. (see e.g. #485, #440, #439) . It also had other problems like weird words.

The best I found so far and could serve as a starting point was a gist from @MarvinJWendt, see https://gist.github.com/MarvinJWendt/2f4f4154b8ae218600eb091a5706b5f4

Instead of ~8MB it's even bigger (~29MB), it's in UTF-8.

Cheers, Dirk

This is a complete replacement of lang-german.txt. As mentioned before
the list was in wrong format (7 Bit) and couldn't reflect the German
Umlaute (see e.g. danielmiessler#485, danielmiessler#440, danielmiessler#439) at all.

The best I found so far and could serve as a starting point was
a gist from @MarvinJWendt, see

https://gist.github.com/MarvinJWendt/2f4f4154b8ae218600eb091a5706b5f4

Instead of ~8MB it's even bigger (~29MB).

Cheers, Dirk
@g0tmi1k g0tmi1k merged commit fbe21a0 into danielmiessler:master Sep 16, 2020
@g0tmi1k g0tmi1k self-assigned this Sep 16, 2020
@g0tmi1k g0tmi1k added the enhancement Enhancement label Sep 16, 2020
@g0tmi1k
Copy link
Collaborator

g0tmi1k commented Sep 16, 2020

Thank you! 🎉

@drwetter drwetter deleted the fix_germanpw.txt branch September 16, 2020 06:37
@drwetter
Copy link
Contributor Author

sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants