policy: revise manifest.js to avoid empty blocks

PR-URL: nodejs#41831 Backport-PR-URL: nodejs#42160 Refs: https://eslint.org/docs/rules/no-empty Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
danielleadams · Mar 4, 2022 · 4a75e86 · 4a75e86
1 parent 7bf4fbc
commit 4a75e86
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/lib/internal/policy/manifest.js b/lib/internal/policy/manifest.js
@@ -430,12 +430,11 @@ class Manifest {
 
     if (objectButNotArray(obj) && 'onerror' in obj) {
       const behavior = obj.onerror;
-      if (behavior === 'throw') {
-      } else if (behavior === 'exit') {
+      if (behavior === 'exit') {
         reaction = REACTION_EXIT;
       } else if (behavior === 'log') {
         reaction = REACTION_LOG;
-      } else {
+      } else if (behavior !== 'throw') {
         throw new ERR_MANIFEST_UNKNOWN_ONERROR(behavior);
       }
     }
@@ -579,8 +578,7 @@ class Manifest {
         const entry = this.#scopeIntegrities.get(scope);
         if (entry === true) {
           return true;
-        } else if (entry === kCascade) {
-        } else {
+        } else if (entry !== kCascade) {
           break;
         }
       }