Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(solarsystem) use km as length unit for solar system setup #629

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

danieljprice
Copy link
Owner

Type of PR:
Bug fix

Description:

  • Using au as the units for small bodies in the solar system causes problems with finite precision (round off error). This is now changed to km as the length unit
  • fix issue with datetime string for epoch being converted automatically
  • better error handling if ephemeris files cannot be downloaded

Testing:

  • checked that orbits of the 9 planets+moon still works in these units

Did you run the bots? no

Did you update relevant documentation in the docs directory? no

…; fix issue with datetime string for epoch being converted automatically
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant