Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacing core of a star in TDE with sink particle + set AGB star from KEPLER file #628

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Replacing core of a star in TDE with sink particle + set AGB star from KEPLER file #628

wants to merge 10 commits into from

Conversation

msha0023
Copy link
Collaborator

@msha0023 msha0023 commented Mar 2, 2025

Type of PR:
Modification to existing code + bug fixes

Description:

  1. We can relax an AGB star in phantom
  2. We can replace the star core with a sink particle. User needs to specify the radius of the remnant only.
  3. Bug fixed for calculating sink-gas force correctly by using omp critical. Tried reduction but that did not work.

Testing:

  1. Sink-sink binary orbit in isolation.
  2. Sink-gas star binary orbit in isolation.
  3. Core replaced with sink particle for a TDE.

Did you run the bots? no

Did you update relevant documentation in the docs directory? no

Megha Sharma added 10 commits February 28, 2025 14:17
(step_leapfrog.f90) dextforce is calculated after get_grforce_all and…
c23058d 
… get_accel_sink_gas now
(substepping.f90) Added omp critical which only works when sink parti…
ce2ccd1 
…cles are used so that sink-gas force is correct
(readwrite_kepler) writes a mass array and H1 and He4 mass fractions
ced2409
(relax_star.f90) moves sink to (100,0,0) when relaxing the star
256c2ba
(Set_star.f90) prompts the user to select core softeneing for kepler …
f7ec5f2 
…stars now
(set_star_utils.f90) Writes softenedprofile for Kepler stars now
7ef4f7d
(setup_grtde.f90) moves sink particle to the position we want on the …
8548c5d 
…orbit
(substepping.f90) dtextforce_min calculated inside if statement of np…
6fe4d36 
…tmass>0 in GR case
Can replace the core of a star in TDE simulation with a sink particle…
01b849f 
… now
(moddump_tdesink.f90) was using squared distance instead of distance,…
c157046 
… fixed it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@msha0023