Set binary fixes #600
Merged
Set binary fixes #600
+950
−732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a module; adjust subroutine calls to account for this
…esolved by the grid; adjust dr until resolved
… and orbital properties when setting up stars and binary systems; shift equation of state options for stars inside set_stars options routines
… includes eos, relax and apr options needed for one or more stars
…tde and star setups
…defaults in msun and rsun; also fix issues with adding stars to grdisc
…tar; issues with piecewise polytrope fixed
…orrect divide-by-mstar in relaxation routine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
new feature
Description:
In the .setup files for setting up stars or binary stars, the user can now enter stellar masses, radii, separations in arbitrary units (e.g. "1*au") and the code will automatically convert these into code units. By default quantities entered without units are given in code units.
This pull request also moves options related to setting the equation of state from setup_star.f90 into the more general routine set_stars (in set_star.f90), so that these can be called from multiple places. The procedure to set up and relax multiple stars is now to call set_stars() which will automatically add EOS and relaxation options.
The output profile (relax1.profile) file output for each star (containing density vs radius for the stellar profile) now contains labels in the header which are useful when plotting this file
the density profile for each star is now output by default in a file called relax1.profile, relax2.profile etc, and is automatically read by splash if present for ease of comparison with the exact solution
Testing:
Did you run the bots? yes
Did you update relevant documentation in the docs directory? no