Add the option to integrate ptmass with 4th order scheme (FSI) #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieljprice
reviewed
Apr 3, 2024
src/main/config.F90
Outdated
| @@ -122,6 +122,13 @@ module dim | |||
| logical, parameter :: do_radiation = .false. | |||
| #endif | |||
|
|
|||
| ! Regularisation method and/or higher order integrator | |||
There was a problem hiding this comment.
see #55, this really should be a runtime parameter, not a compile-time parameter. Suggest to remove the #ifdef here...
build/Makefile
Outdated
| @@ -274,6 +274,10 @@ ifeq ($(RADIATION), yes) | |||
| FPPFLAGS += -DRADIATION | |||
| endif | |||
|
|
|||
| ifeq ($(FOURTHORDER), yes) | |||
| FPPFLAGS += -DFOURTHORDER | |||
| endif | |||
There was a problem hiding this comment.
same comment as below... no new ifdefs!
src/main/ptmass.F90
Outdated
| @@ -110,6 +111,27 @@ module ptmass | |||
| private | |||
|
|
|||
| contains | |||
|
|
|||
| !---------------------------------------------------------------- | |||
There was a problem hiding this comment.
I will open an issue on this, we should fix the kernel-generating python script to also produce this routine #523
src/main/step_leapfrog.F90
Outdated
| @@ -1048,6 +1053,393 @@ subroutine step_extern_sph(dt,npart,xyzh,vxyzu) | |||
|
|
|||
| end subroutine step_extern_sph | |||
|
|
|||
| !---------------------------------------------------------------- | |||
There was a problem hiding this comment.
I think we should move all step_extern routines into a separate module (step_extern.f90 ?)
…nto 4thorder_scheme
|
something wrong appends with the quintic kernel module... There is no new grad kernel |
…aks on FSI routines
…rce or oblateness
…hi still needs to be low if an orbit is really eccentric
…e, also ability to run specific tests in ptmass testsuite
…nto 4thorder_scheme
…x weird build failure with ifort on Mac
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
New integration method
Description:
Add new 4th order integration schemes for point mass evolution. At this moment, The FSI and PEFRL are implemented.
Only the gravitational interactions are taken into account. The PEFRL is certainly not well suited for Phantom ( due to backward step). To extend the FSI to all other interactions, it is needed to compute the gradient term for each of them in the middle kick phase. cf : Chin (2007a) 10.1103/PhysRevE.75.036701
Testing:
To test these methods, I reused the galcen setup without gas injection. Then the system of point masses is integrated during a short period and a check on the energy and angular momentum conservation is performed. A little test with 2 point masses is also done to check if the evolution correspond to a keplerian motion.
Did you run the bots? no
Did you update relevant documentation in the docs directory? no