Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimise implicit radiation solving #458

Merged
merged 11 commits into from
Jul 28, 2023
Merged

Optimise implicit radiation solving #458

merged 11 commits into from
Jul 28, 2023

Conversation

themikelau
Copy link
Collaborator

Summary of changes:

  • Iterate only over subset of particles that have not converged.
  • Lower tol_rad from 10^-5 to 10^-6 in test suite so that calculation of dxi/dt with implicit radiation is accurate enough when iterating over individual particles.
  • Move allocation of compacted neighbour list and neighbour arrays into new module implicit (utils_implicit.f90).
  • Only allocate arrays if unallocated, as opposed to doing so every time step.
  • Remove calculation of redundant dvdx in fill_arrays (it is identical to the calculation in density). Remove check for dvdx in the test suite.
  • Put calculation of flux limiter lambda and Eddington factor into the compute_flux particle loop. Remove timing for computing lambda and eddington.
  • Cache cv, lambda, eddington, and opacity in EU0(6,npart) array.

@danieljprice danieljprice merged commit 5378176 into master Jul 28, 2023
@danieljprice danieljprice deleted the rad-pcle-mask branch July 28, 2023 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants